[DataGrid] Fix crash when grouping/tree-data values match Object.prototype property names

packages/x-data-grid-premium/src/tests/rowGrouping.DataGridPremium.test.tsx

@@ -251,6 +251,35 @@ describe('<DataGridPremium /> - Row grouping', () => {
         '',
       ]);
     });
+
+    // Regression test for https://github.com/mui/mui-x/issues/22310
+    it('should not crash when grouping values match Object.prototype property names', () => {
+      render(
+        <Test
+          rows={[
+            { id: 0, category1: 'constructor', category2: 'Cat 1' },
+            { id: 1, category1: 'constructor', category2: 'Cat 2' },
+            { id: 2, category1: '__proto__', category2: 'Cat 1' },
+            { id: 3, category1: 'toString', category2: 'Cat 2' },
+            { id: 4, category1: 'hasOwnProperty', category2: 'Cat 1' },
+          ]}
+          initialState={{ rowGrouping: { model: ['category1'] } }}
+          defaultGroupingExpansionDepth={-1}
+        />,
+      );
+
+      expect(getColumnValues(0)).to.deep.equal([
+        'constructor (2)',
+        '',
+        '',
+        '__proto__ (1)',
+        '',
+        'toString (1)',
+        '',
+        'hasOwnProperty (1)',
+        '',
+      ]);
+    });
   });
 
   describe('colDef: groupingValueGetter & valueGetter', () => {

packages/x-data-grid-pro/src/hooks/features/treeData/treeDataReorderExecutor.ts

@@ -381,7 +381,7 @@ class DropOnLeafOperation extends BaseReorderOperation {
         ...targetNode,
         type: 'group',
         children: [sourceNode.id],
-        childrenFromPath: {},
+        childrenFromPath: Object.create(null),
         groupingField: null,
         isAutoGenerated: false,
         childrenExpanded: true,

packages/x-data-grid-pro/src/tests/treeData.DataGridPro.test.tsx

@@ -231,6 +231,21 @@ describe('<DataGridPro /> - Tree data', () => {
         'C',
       ]);
     });
+
+    // Regression test for https://github.com/mui/mui-x/issues/22310
+    it('should not crash when path segments match Object.prototype property names', () => {
+      render(
+        <Test
+          rows={[
+            { id: 0, name: 'constructor.leaf1' },
+            { id: 1, name: 'constructor.leaf2' },
+          ]}
+          getRowId={(row) => row.id}
+          defaultGroupingExpansionDepth={-1}
+        />,
+      );
+      expect(getColumnValues(1)).to.deep.equal(['', 'constructor.leaf1', 'constructor.leaf2']);
+    });
   });
 
   describe('prop: defaultGroupingExpansionDepth', () => {

packages/x-data-grid-pro/src/utils/tree/insertDataRowInTree.ts

@@ -105,7 +105,7 @@ export const insertDataRowInTree = ({
             groupingKey: key,
             groupingField: field,
             children: [],
-            childrenFromPath: {},
+            childrenFromPath: Object.create(null),
             childrenExpanded: false,
             serverChildrenCount,
           };
@@ -172,7 +172,7 @@ export const insertDataRowInTree = ({
         groupingKey: key,
         groupingField: field,
         children: [],
-        childrenFromPath: {},
+        childrenFromPath: Object.create(null),
         childrenExpanded: false,
       };
 
@@ -207,7 +207,7 @@ export const insertDataRowInTree = ({
           groupingKey: key,
           groupingField: field,
           children: [],
-          childrenFromPath: {},
+          childrenFromPath: Object.create(null),
           childrenExpanded: false,
         };
         tree[existingNodeIdWithPartialPath] = updateGroupDefaultExpansion(

packages/x-data-grid-pro/src/utils/tree/utils.ts

@@ -125,9 +125,9 @@ export const insertNodeInTree = (
     }
 
     if (groupingField == null) {
-      parentNode.childrenFromPath[groupingFieldName] = {
-        [groupingKeyName.toString()]: node.id,
-      };
+      const newGroupingField = Object.create(null);
+      newGroupingField[groupingKeyName.toString()] = node.id;
+      parentNode.childrenFromPath[groupingFieldName] = newGroupingField;
     } else {
       groupingField[groupingKeyName.toString()] = node.id;
     }

packages/x-data-grid/src/hooks/features/rows/gridRowsUtils.ts

@@ -41,7 +41,9 @@ export const buildRootGroup = (): GridGroupNode => ({
   groupingKey: null,
   isAutoGenerated: true,
   children: [],
-  childrenFromPath: {},
+  // Prototype-less so user-supplied grouping values like `'constructor'`
+  // or `'__proto__'` cannot collide with `Object.prototype` properties.
+  childrenFromPath: Object.create(null),
   childrenExpanded: true,
   parent: null,
 });