feat(measurement): enforce finite Distance magnitudes#599
Merged
mtrewartha merged 2 commits intomainfrom Mar 8, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Throw IllegalArgumentException when constructing a Distance with a NaN or infinite magnitude. Update tests to cover the new validation and fix all property-based tests that previously used Arb.double() (which can produce non-finite values). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
mtrewartha
force-pushed
the
finite-distances
branch
from
05c5fb3 to
a83f964
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
initblock toDistancethat throwsIllegalArgumentExceptionwith a descriptive message when constructed with a NaN or infinite magnitudeDistanceTestto cover the new validation (three new cases: finite succeeds, NaN throws, infinite throws)Arb.double()(which can produce non-finite values) to useArb.numericDouble()insteadCloses POS-29
Test plan
./gradlew :core:measurement:testpasses