Skip to content

Add sliding window#684

Open
pavlis wants to merge 4 commits intomasterfrom
add_sliding_window
Open

Add sliding window#684
pavlis wants to merge 4 commits intomasterfrom
add_sliding_window

Conversation

@pavlis
Copy link
Collaborator

@pavlis pavlis commented Feb 4, 2026

This branch implements the sliding window algorithm with Futures whose development is described in Discussion #656. I've also included a complete pytest suite for the function to verify all features work - at least on simple data.

mspass-team members please evaluate the api critically. Also because this is a generic function are there additional sanity checks on the arguments that need to be added?

Hopefully this will pass tests clean, but it is possible the use of a dask.distributed.LocalCluster may behave differently on github than on the machine I ran pytest.

@pavlis
Copy link
Collaborator Author

pavlis commented Feb 4, 2026

Something is breaking in the ml library. Pull request #682 is failing for the same reason. @wangyinz I hope you can resolve this as I have no idea how to fix it.

@codecov
Copy link

codecov bot commented Feb 7, 2026

Codecov Report

❌ Patch coverage is 96.15385% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.46%. Comparing base (bff2a3e) to head (d5743aa).

Files with missing lines Patch % Lines
python/mspasspy/workflow.py 96.15% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #684      +/-   ##
==========================================
+ Coverage   59.11%   59.46%   +0.34%     
==========================================
  Files         158      159       +1     
  Lines       25909    26013     +104     
  Branches     1520     1520              
==========================================
+ Hits        15317    15468     +151     
+ Misses      10125    10079      -46     
+ Partials      467      466       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants