Skip to content

Possible to solve memory leak#240

Open
mortenholmgaard wants to merge 10 commits intomrmans0n:masterfrom
mortenholmgaard:master
Open

Possible to solve memory leak#240
mortenholmgaard wants to merge 10 commits intomrmans0n:masterfrom
mortenholmgaard:master

Conversation

@mortenholmgaard
Copy link
Copy Markdown

This change make it possible to fix a memory leak in leaking listener in LocationGooglePlayServicesProvider.java and LocationGooglePlayServicesWithFallbackProvider.java

private var locationControl: SmartLocation.LocationControl? = null
locationControl = SmartLocation.with(context).location()
locationControl!!.oneFix().start { location ->
...
}

override fun onDestroy() {
    locationControl?.destroy()
    super.onDestroy()
}

@mortenholmgaard mortenholmgaard mentioned this pull request Jun 25, 2018
@ugurcany
Copy link
Copy Markdown

ugurcany commented Aug 1, 2018

@mrmans0n please merge this pull request since it resolves a critical memory leak issue. thanks for the library.

@christocracy
Copy link
Copy Markdown

@mortenholmgaard if you hope to have a PR taken seriously, you might want to rebase your branch before submitting:

  • Fix
  • Fix
  • Fix
  • Fix
    .
    .
    .
    etc

@mortenholmgaard
Copy link
Copy Markdown
Author

mortenholmgaard commented Aug 5, 2018

I do not really expect it to be merge because there do not seem to any activity on this lib from the author any way, so it was mostly for my self and others with same problem. So I did not want to spend time on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants