Possible to solve memory leak#240
Open
mortenholmgaard wants to merge 10 commits intomrmans0n:masterfrom
Open
Conversation
…al fix memory leak of "io.nlopez.smartlocation.location.providers.LocationGooglePlayServicesProvider.context"
Closed
|
@mrmans0n please merge this pull request since it resolves a critical memory leak issue. thanks for the library. |
|
@mortenholmgaard if you hope to have a PR taken seriously, you might want to rebase your branch before submitting:
|
Author
|
I do not really expect it to be merge because there do not seem to any activity on this lib from the author any way, so it was mostly for my self and others with same problem. So I did not want to spend time on it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change make it possible to fix a memory leak in leaking listener in LocationGooglePlayServicesProvider.java and LocationGooglePlayServicesWithFallbackProvider.java