Skip to content

🐞 Fix stale isLoopOpen check causing action keys to leak to focused app #1096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mrkai77 merged 1 commit into from
May 11, 2026
+1 −1
Merged

🐞 Fix stale isLoopOpen check causing action keys to leak to focused app #1096

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Loop/Core/Observers/KeybindTrigger.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ final class KeybindTrigger {

// Only consume the event if the last command actually opened Loop.
// The main reason Loop *wouldn't* open after an `openLoop` call would be because the user has enabled a trigger delay.
return isLoopOpen ? .consume : .opening
return checkIfLoopOpen() ? .consume : .opening
}

// Only trigger Loop without an action if the only pressed keys perfectly matches the trigger key.
Expand Down