Open
Conversation
Author
Collaborator
|
I think this bumps the MSRV right? So, might require a major version release. |
Author
|
Ah right, didn't think about that. Using edition 2021 would bump MSRV from 1.46 to 1.56. I propose to keep the edition to 2018 for now and just integrate the benchmark fixes. Fixing the benchmarks doesn't require increasing MSRV. Sounds good? |
fkohlgrueber
force-pushed
the
fix-benches
branch
from
86fae1d to
082532b
Compare
fkohlgrueber
force-pushed
the
fix-benches
branch
from
082532b to
be82a85
Compare
Collaborator
|
plotters-rs/plotters#398 is causing tests to fail, maybe pin the version to v0.3.1? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I did a couple of straight-forward changes such that
cargo benchworks again. I also fixed the deprecation warnings in the benchmarksand changed the rust edition to 2021.Let me know if you want anything changed.