use dedicated heating values with most recent firmware version with 15A hardware - #459
Merged
Merged
Conversation
…e latest firmware
mr-manuel
reviewed
May 23, 2026
There was a problem hiding this comment.
Pull request overview
This PR updates the JKBMS PB driver’s settings parsing to recognize when dedicated heating start/stop temperature registers are supported on hardware version 15A with firmware >= 15.41, and to fall back to the legacy “Bat Charge Under Temperature” thresholds otherwise.
Changes:
- Parse the BMS software version string into a comparable tuple (e.g.,
15.41→(15, 41)), with a safe fallback on parse failure. - Update the heating-threshold selection logic to enable dedicated heating values for
15Aonly whenfw >= 15.41, and for newer hardware unconditionally.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Owner
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The most recent and probably final firmware version v15.41 for the hardware version 15A implemented support for the dedicated heating start and stop values, so use them if available.