Refine page titles as suggested and introduce block page_title_region (#385)
#770
Conversation
| {%- elif LANG == 'en-GB' -%} | ||
| Firefox for Desktop — Firefox (UK) | ||
| {%- if LANG == 'en-US' or LANG == 'en-GB' -%} | ||
| Firefox for Desktop available for Windows, Mac and Linux |
There was a problem hiding this comment.
After outsourcing the region, we could go back to using the FTL files here, right? Or what was the reason they weren't used here in the first place?
janbrasna
left a comment
janbrasna
left a comment
There was a problem hiding this comment.
There definitely are some changes necessary for those repetitive titles, and I would like to see them simplified or rewritten personally.
I'm not sure the questions raised in the tracking ticket were even being considered yet though, they may need to go through martech folks or search agency first.
(But hopefully there will be at least a part of these changes reviewable without external input.)
| {# Issue 13019: Avoid duplicate content for English pages. #} | ||
| {%- block page_title_full -%} | ||
| {%- if LANG == 'en-US' -%} | ||
| Get Firefox for iOS (iPhone and iPad) — Mozilla (US) | ||
| {%- elif LANG == 'en-GB' -%} | ||
| Download Firefox for iOS (iPhone and iPad) — Mozilla (UK) | ||
| {%- if LANG == 'en-US' or LANG == 'en-GB' -%} | ||
| Get Firefox for iOS (iPhone and iPad) from Mozilla |
There was a problem hiding this comment.
The idea of disambiguating the titles across multiple English regions is mainly in changing the wording as whole, to make it more custom. The "Download" vs. "Get" for US × GB is intentional.
Which may actually mean discouraging from just slapping a region suffix through a function — the titles when in risk of duplicate content should be as distinct as possible, esp. including fine tuning the phrasing or vocabulary.
(Which, correctly, would hint at fully localizing them via Fluent +Pontoon then, and just handling the potential suffix programmatically. Thing is, the titles might have been pulled out of community l10n flows for better visibility and direct influence on the content right here in the repo by the team — to actually make sure the linked ticket is sufficiently taken into consideration, and the actual phrasing is deliberately different — which wouldn't have been obvious just from l10n point of view in Pontoon…)
That said, I'm not sure the benefit to make that more systemic is worth the global project impact, as the cases ticketed are hand-picked to be customized. (Which, outside of this PR, is being done in a handful of major pages already; the linked ticket only listed the "leftovers" that might need some more love, but there are also a few more already resolved and worded up to expectations already.)
| {%- if LANG == 'en-US' or LANG == 'en-GB' -%} | ||
| Get Firefox for iOS (iPhone and iPad) from Mozilla | ||
| {%- else -%} | ||
| {{ ftl('mobile-ios-firefox-browser-ios') }} - Mozilla |
There was a problem hiding this comment.
Here BTW the format for RoW seems to keep the old style though then. For not introducing a new l10n string just for potential "from Mozilla" here I guess?
|
|
||
| {% block shared_meta %} | ||
| <title>{% filter striptags %}{% block page_title_full %}{% block page_title_prefix %}{% endblock %}{% block page_title %}{% endblock %}{% endblock page_title_full %}{% block page_title_suffix %} — Firefox{% endblock %}{% endfilter %}</title> | ||
| <title>{% filter striptags %}{% block page_title_full %}{% block page_title_prefix %}{% endblock %}{% block page_title %}{% endblock %}{% endblock page_title_full %}{% block page_title_suffix %} — Firefox.com{% endblock %}{% block page_title_region %}{% endblock %}{% endfilter %}</title> |
There was a problem hiding this comment.
Given this is a global base template, I'd ask around first if that is a pattern worth encouraging in the first place.
My understanding is when a customization is necessary, there's a reason, and it should be explicit at that exact page, with ideally tailored titles fully.
(Not sure if the concern is still valid after these years though. Figured a reviewer will have some guidance.)
3 participants
Introduced a
block page_title_regionto cleanly append region names to selected English pages, preventing duplicate content (issue 13019). Also changed "Firefox" to "Firefox.com".Testing: