Performance improvement by fixing python loop over bytes#2824
Open
Hollyqui wants to merge 2 commits intomozilla:mainfrom
Open
Performance improvement by fixing python loop over bytes#2824Hollyqui wants to merge 2 commits intomozilla:mainfrom
Hollyqui wants to merge 2 commits intomozilla:mainfrom
Conversation
Improving performance significantly by not looping over bytes individually but just allocating buffer directly.
mhammond
reviewed
Feb 16, 2026
uniffi_bindgen/src/bindings/python/templates/RustBufferTemplate.py
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improving performance significantly by not looping over bytes individually but just allocating buffer directly. For detailed description see here: n0-computer/iroh-ffi#229, I noticed this when working with iroh where the loop reduces transfer speeds significantly.