Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for records implementing trait interfaces (previously only objects could). On the Kotlin side this is straightforward. The record's data class declaration includes the trait interfaces. On the Swift side, the main design decision is around
AnyObject. Existing...Protocoltypes all extendAnyObject, which prevents value types (structs) from conforming. To solve this without breaking existing code, a newAny...Protocolis generated without theAnyObjectconstraint, and the existing...Protocolinherits from bothAnyObjectandAny...Protocol. Records then conform toAny...Protocol.It should be noted that I am not super familiar with Swift, Kotlin, or the uniffi codebase, so I did use Claude for some of the work in this PR.
Closes #2819
TODO: