Skip to content

Allow hyphen values for secret key option #2667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
darallium wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Allow hyphen values for secret key option #2667

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
618949e
Allow hyphen values for secret key option
darallium Apr 5, 2026
81b030d
Added test for allow hyphen values for sccache-dist secret key option
darallium Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 23 additions & 1 deletion src/bin/sccache-dist/cmdline/parse.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,8 @@ fn get_clap_command() -> ClapCommand {
.required(true),
flag_infer_long("secret-key")
.help("Use specified key to create the token")
.value_name("KEY"),
.value_name("KEY")
.allow_hyphen_values(true),
config_with_help_message(
"Use the key from the scheduler config file at PATH",
),
Expand Down Expand Up @@ -349,6 +350,26 @@ mod tests {
);
}

#[test]
fn auth_generate_jwt_hs256_server_token_allows_hyphenated_secret_key() {
let args = auth_generate_jwt_hs256_server_token(&[
"--server",
"127.0.0.1:4321",
"--secret-key",
"-9DumMyDuMMyRV6hR4sb37JFaVEmSiXVPKr-dummykU",
]);
let server_socket: SocketAddr = "127.0.0.1:4321".parse().unwrap();
let server_id = ServerId::new(server_socket);

assert_args_parse_to_auth(
args,
AuthSubcommand::JwtHS256ServerToken {
server_id,
secret_key: "-9DumMyDuMMyRV6hR4sb37JFaVEmSiXVPKr-dummykU".to_owned(),
},
);
}

#[test]
fn auth_generate_shared_token_good() {
let raw_to_expected_bit_vals = &[
Expand All @@ -368,4 +389,5 @@ mod tests {
);
}
}

}