Skip to content

Static-link s390x and riscv64 musl; Add static-link check #2658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Xeonacid wants to merge 1 commit into
base: main
Choose a base branch
from
+16 −0
Open

Static-link s390x and riscv64 musl; Add static-link check #2658

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,12 +262,14 @@ jobs:
- os: ubuntu-22.04
target: s390x-unknown-linux-musl
container: '{"image": "messense/rust-musl-cross:s390x-musl"}'
rustflags: -Ctarget-feature=+crt-static
Comment thread
Xeonacid marked this conversation as resolved.
lto: "false"
- os: ubuntu-22.04
target: s390x-unknown-linux-gnu
- os: ubuntu-22.04
target: riscv64gc-unknown-linux-musl
container: '{"image": "messense/rust-musl-cross:riscv64gc-musl"}'
rustflags: -Ctarget-feature=+crt-static
lto: "false"
- os: ubuntu-22.04
binary: sccache-dist
Expand Down Expand Up @@ -356,6 +358,20 @@ jobs:
RUSTFLAGS: ${{ env.RUSTFLAGS || matrix.rustflags }}
CARGO_PROFILE_RELEASE_LTO: ${{ matrix.lto || 'true' }}

- name: Verify static linking for musl artifacts
if: ${{ contains(matrix.target, '-unknown-linux-musl') }}
run: |
BINARY="target/${{ matrix.target }}/release/${{ matrix.binary || 'sccache' }}"
[ -f "$BINARY" ] || { echo "Error: expected binary not found at $BINARY"; exit 1; }
NEEDED_PATTERN='^[[:space:]]*0x[0-9a-fA-F]+[[:space:]]+\(NEEDED\)[[:space:]]+Shared library:'
DYNAMIC_SECTION="$(readelf -d "$BINARY")"
Comment thread
Xeonacid marked this conversation as resolved.
echo "$DYNAMIC_SECTION"
if echo "$DYNAMIC_SECTION" | grep -Eq "$NEEDED_PATTERN"; then
echo "Expected a statically linked musl binary, but found dynamic dependencies:"
echo "$DYNAMIC_SECTION" | grep -E "$NEEDED_PATTERN"
exit 1
fi

# Workaround for the lack of substring() function in github actions expressions.
- name: Id
id: id
Expand Down
Loading