D3 chartjs migration#7520
Merged
Merged
Conversation
* Switch to chart.js * Drop D3
escattone
approved these changes
Jun 3, 2026
| } from "chart.js"; | ||
| // Side-effect import: registers the date-fns adapter with Chart.js | ||
| import "chartjs-adapter-date-fns"; | ||
| import { MatrixController, MatrixElement } from "chartjs-chart-matrix"; |
Contributor
There was a problem hiding this comment.
These are imported but never used. Maybe remove them and the chartjs-chart-matrix" dependency until a use case arises?
| return new Chart(el, config); | ||
| } | ||
|
|
||
| export function renderMatrixChart(el, config) { |
Contributor
There was a problem hiding this comment.
This is never used either. Maybe remove until a use case arises?
Contributor
|
Oh, I forgot one thing. If they don't already comply, I think we should configure the chart colors to comply with the |
* Drop unsed imports
akatsoulas
force-pushed
the
d3-chartjs-migration
branch
from
7f49de1 to
a20c946
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.