CRUD for PromotedGroup via django admin#25179
Open
eviljeff wants to merge 1 commit into
Open
Conversation
eviljeff
force-pushed
the
16342-promotedgroup-django-admin
branch
from
July 22, 2026 12:13
5ebb203 to
781026f
Compare
eviljeff
marked this pull request as ready for review
July 22, 2026 12:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes mozilla/addons#16342
Description
Enables django admin create, update, and delete for PromotedGroup instances so add-ons Operations (well, admins) can manage PromotedGroups themselves. Triggers elasticsearch reindexes if changes are made to public groups.
Context
Changing badged groups isn't possible unless/until we resolve mozilla/addons#16341
I did consider adding further guard-rails for public groups - especially badged groups - because frontend is going exhibit changes immediately if you do something such as changing api_name, but left it at a warning in the field label instead. It's complicated - api_names such as spotlight have side-effects (e.g. warning being removed) that we can't account for in addons-server, and
notableisn't even a public group and it's api_name is important. For now, it's locked down to*:*anyway, but especially if it's opened up to users with narrower permissions we should reconsider more guard-rails.Testing
http://olympia.test/api/v5/addons/search/?q=<whatever the add-on is named>Checklist
#ISSUENUMat the top of your PR to an existing open issue in the mozilla/addons repository.