Skip to content

CRUD for PromotedGroup via django admin#25179

Open
eviljeff wants to merge 1 commit into
mozilla:masterfrom
eviljeff:16342-promotedgroup-django-admin
Open

CRUD for PromotedGroup via django admin#25179
eviljeff wants to merge 1 commit into
mozilla:masterfrom
eviljeff:16342-promotedgroup-django-admin

Conversation

@eviljeff

@eviljeff eviljeff commented Jul 22, 2026

Copy link
Copy Markdown
Member

Fixes mozilla/addons#16342

Description

Enables django admin create, update, and delete for PromotedGroup instances so add-ons Operations (well, admins) can manage PromotedGroups themselves. Triggers elasticsearch reindexes if changes are made to public groups.

Context

Changing badged groups isn't possible unless/until we resolve mozilla/addons#16341

I did consider adding further guard-rails for public groups - especially badged groups - because frontend is going exhibit changes immediately if you do something such as changing api_name, but left it at a warning in the field label instead. It's complicated - api_names such as spotlight have side-effects (e.g. warning being removed) that we can't account for in addons-server, and notable isn't even a public group and it's api_name is important. For now, it's locked down to *:* anyway, but especially if it's opened up to users with narrower permissions we should reconsider more guard-rails.

Testing

Checklist

  • Add #ISSUENUM at the top of your PR to an existing open issue in the mozilla/addons repository.
  • Successfully verified the change locally.
  • The change is covered by automated tests, or otherwise indicated why doing so is unnecessary/impossible.
  • Add before and after screenshots (Only for changes that impact the UI).
  • Add or update relevant docs reflecting the changes made.

@eviljeff
eviljeff force-pushed the 16342-promotedgroup-django-admin branch from 5ebb203 to 781026f Compare July 22, 2026 12:13
@eviljeff
eviljeff marked this pull request as ready for review July 22, 2026 12:23
@eviljeff
eviljeff requested review from a team and diox and removed request for a team July 22, 2026 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Task]: Add an admin to PromotedGroup to allow create/edit/delete [Task]: Allow promoted groups to be added/removed to/from badged dynamically

1 participant