Misc updates for making CSP headers work#98
Merged
bheesham merged 7 commits intomozilla-iam:masterfrom Oct 17, 2025
Merged
Conversation
Jira: IAM-1775
Jira: IAM-1775
Jira: IAM-1775
Jira: IAM-1775
There was a problem hiding this comment.
Pull Request Overview
This PR updates CSP (Content Security Policy) headers configuration to work with the ingress controller by enabling snippet annotations and restructuring security header implementation.
- Enables snippet annotations in the ingress controller configuration
- Restructures CSP headers from a single line to multiple separate header directives
- Removes public/private environment conditional logic and related routing rules
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| k8s/values/test.yaml | Removes public flag from test environment configuration |
| k8s/values.yaml | Removes public flag from default values |
| k8s/templates/router.yaml | Removes conditional public routing logic |
| k8s/templates/public-splitter.yaml | Updates location patterns and removes CSP header, simplifies logout redirect logic |
| k8s/templates/ingress.yaml | Restructures CSP and security headers from single line to multiple separate directives |
| k8s/templates/ingress-controller.yaml | Enables snippet annotations and adds events RBAC permissions |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Jira: IAM-1775
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out the ingress controller was not acting on the
nginx.ingress.kubernetes.io/configuration-snippetannotation because we didn't configure it to (or perhaps the defaults changed).This also sets up some rules to deal with mozilla-iam/dino-park-front-end#716.
Jira: IAM-1775