Add OCI (Oracle Cloud Infrastructure) cloud provider support#326
Open
cvilodub wants to merge 1 commit into
Open
Add OCI (Oracle Cloud Infrastructure) cloud provider support#326cvilodub wants to merge 1 commit into
cvilodub wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Oracle Cloud Infrastructure (OCI) managed PostgreSQL, like AWS RDS and GCP
AlloyDB, does not grant the admin user full superuser privileges. This means
certain operations require the admin user to belong to the target
role(s) before they can succeed. Without a dedicated provider wrapper,
CreateDBandDropRolefail against OCI PostgreSQL.This PR adds an OCI provider wrapper that mirrors the workarounds already in
place for AWS and GCP:
CreateDB: grants the admin user membership in the target role beforecalling
ALTER DATABASE ... OWNER TO, then delegates to the baseimplementation.
DropRole: grants the admin user membership in both the role beingdropped and the new owner role (required for
REASSIGN OWNED BY), withappropriate handling for the "already a member" (
0LP01) and "role does notexist" (
42704) error codes. The new-owner grant is revoked viadeferafter the drop completes.
Changes
pkg/config/config.go: addCloudProviderOCIconstant and"oci"case inParseCloudProvider.pkg/postgres/oci.go: new file implementing theocipgwrapper withCreateDBandDropRoleoverrides.pkg/postgres/postgres.go: wireCloudProviderOCIinto theNewPGfactory.Testing
Tested against an OCI PostgreSQL instance with the operator configured with
cloudProvider: OCI. Database and role lifecycle operations all complete successfully.