Skip to content

Use Qt6 on Rolling and newer distros#3707

Merged
nbbrooks merged 6 commits intomoveit:mainfrom
nbbrooks:pr-qt6-support
Mar 23, 2026
Merged

Use Qt6 on Rolling and newer distros#3707
nbbrooks merged 6 commits intomoveit:mainfrom
nbbrooks:pr-qt6-support

Conversation

@nbbrooks
Copy link
Contributor

@nbbrooks nbbrooks commented Mar 16, 2026

Description

Rviz switchd to Qt6 in version 15.1 ros2/rviz#1635

As we support the latest features in main being source built to non-EOL distros, the following cases must be supported

  • Humble (Ubuntu 22.04): Use Qt5
  • Jazzy (Ubuntu 24.04): Use Qt5
  • Kilted (Ubuntu 24.04): Use Qt5
  • Rolling (currently Ubuntu 42.04): Use Qt6

There are some specific checks in here to handle cases where Qt5 and Qt6 are installed.

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@codecov
Copy link

codecov bot commented Mar 16, 2026

Codecov Report

❌ Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 46.22%. Comparing base (f1135a4) to head (687f30f).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...plugin/src/motion_planning_frame_joints_widget.cpp 0.00% 2 Missing ⚠️
...eit_setup_framework/src/xml_syntax_highlighter.cpp 0.00% 2 Missing ⚠️
..._setup_srdf_plugins/src/collision_linear_model.cpp 0.00% 2 Missing ⚠️
..._setup_srdf_plugins/src/collision_matrix_model.cpp 0.00% 2 Missing ⚠️
...tup_srdf_plugins/src/default_collisions_widget.cpp 0.00% 2 Missing ⚠️
...planning_rviz_plugin/src/motion_planning_frame.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            main    #3707       +/-   ##
==========================================
+ Coverage   0.00%   46.22%   +46.22%     
==========================================
  Files        539      726      +187     
  Lines      47592    59497    +11905     
  Branches    6085     7624     +1539     
==========================================
+ Hits           0    27499    +27499     
+ Misses     47592    31832    -15760     
- Partials       0      166      +166     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

…d the default CMake ascending ordering resolving to Qt5.

- For Rolling, Qt6 should be used if both are present
- For Jazzy and Kilted, Qt5 should be used if both are present, but this will not cover that edge case
…case for Jazzy/Kilted with both Qt6 and Qt5, where Qt5 should be picked.
@nbbrooks nbbrooks changed the title Another take on Qt6 support Use Qt6 on Rolling and newer distroes Mar 22, 2026
…but incorrectly resolve to Qt5 due to default cmake order resolution
@nbbrooks nbbrooks changed the title Use Qt6 on Rolling and newer distroes Use Qt6 on Rolling and newer distros Mar 23, 2026
@nbbrooks
Copy link
Contributor Author

nbbrooks commented Mar 23, 2026

The [CI / rolling-ci + ikfast + clang-tidy](https://github.com/moveit/moveit2/actions/runs/23422946195/job/68131764804?pr=3707) failure appears unrelated to the Qt5/Qt6 issues that are present on main.

@nbbrooks nbbrooks enabled auto-merge (squash) March 23, 2026 06:24
@nbbrooks nbbrooks requested a review from stephanie-eng March 23, 2026 06:25
@nbbrooks nbbrooks disabled auto-merge March 23, 2026 06:26
@nbbrooks nbbrooks merged commit 6914697 into moveit:main Mar 23, 2026
8 of 11 checks passed
@github-project-automation github-project-automation bot moved this to ✅ Done in MoveIt Mar 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant