Update deprecated usage of get_package_share without std::filesystem::path#3703
Merged
nbbrooks merged 6 commits intomoveit:mainfrom Mar 23, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3703 +/- ##
==========================================
+ Coverage 0.00% 46.28% +46.28%
==========================================
Files 539 726 +187
Lines 47592 59495 +11903
Branches 6085 7623 +1538
==========================================
+ Hits 0 27533 +27533
+ Misses 47592 31794 -15798
- Partials 0 168 +168 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
stephanie-eng
force-pushed
the
seng/update-get-package-share
branch
3 times, most recently
from
f9eb433 to
f0b9544
Compare
Contributor
|
No, this is to address ament/ament_index#104 in Rolling distro - ament/ament_index#112 is not released to debians yet. |
Timple
reviewed
Mar 15, 2026
moveit_setup_assistant/moveit_setup_framework/include/moveit_setup_framework/utilities.hpp
Show resolved
Hide resolved
Timple
reviewed
Mar 15, 2026
6 tasks
Contributor
|
@stephanie-eng could you turn on "Allow edits from maintainers" so I can push some changes? For now I duplicated this PR in #3705 |
Contributor
Author
|
|
This reverts commit f0b9544. Qt6 migration will be handled in a separate branch. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
nbbrooks
force-pushed
the
seng/update-get-package-share
branch
from
a3d95b1 to
8bef942
Compare
Contributor
|
Looks like I missed a QT migration I'll address in a followup - in previous PRs I recall the deprecation check failing on get_package_share deprecations but I do not see this here so LGTM. /home/runner/work/moveit2/moveit2/.work/target_ws/src/moveit2/moveit_setup_assistant/moveit_setup_srdf_plugins/src/collision_linear_model.cpp: In function ‘bool moveit_setup::srdf_setup::compareVariants(const QVariant&, const QVariant&)’:
/home/runner/work/moveit2/moveit2/.work/target_ws/src/moveit2/moveit_setup_assistant/moveit_setup_srdf_plugins/src/collision_linear_model.cpp:279:42: error: ‘Type’ is deprecated: Use QMetaType::Type instead. [-Werror=deprecated-declarations]
279 | if (left.userType() == QVariant::Type::Int)
| ^~~
In file included from /usr/include/x86_64-linux-gnu/qt6/QtCore/qabstractitemmodel.h:11,
from /usr/include/x86_64-linux-gnu/qt6/QtCore/qabstractproxymodel.h:7,
from /usr/include/x86_64-linux-gnu/qt6/QtCore/QAbstractProxyModel:1,
from /home/runner/work/moveit2/moveit2/.work/target_ws/src/moveit2/moveit_setup_assistant/moveit_setup_srdf_plugins/include/moveit_setup_srdf_plugins/collision_linear_model.hpp:39,
from /home/runner/work/moveit2/moveit2/.work/target_ws/src/moveit2/moveit_setup_assistant/moveit_setup_srdf_plugins/src/collision_linear_model.cpp:37:
/usr/include/x86_64-linux-gnu/qt6/QtCore/qvariant.h:61:70: note: declared here
61 | enum QT_DEPRECATED_VERSION_X_6_0("Use QMetaType::Type instead.") Type
| ^~~~
At global scope:
cc1plus: note: unrecognized command-line option ‘-Wno-unknown-warning-option’ may have been intended to silence earlier diagnostics
cc1plus: all warnings being treated as errors
gmake[2]: *** [CMakeFiles/moveit_setup_srdf_plugins.dir/build.make:90: CMakeFiles/moveit_setup_srdf_plugins.dir/src/collision_linear_model.cpp.o] Error 1
gmake[1]: *** [CMakeFiles/Makefile2:166: CMakeFiles/moveit_setup_srdf_plugins.dir/all] Error 2
gmake: *** [Makefile:146: all] Error 2
---
Failed <<< moveit_setup_srdf_plugins [41.2s, exited with code 2] |
nbbrooks
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
CI appears to be borked. Maybe this will help.
Checklist