fix: make context cancel unconditional in flush#15
Merged
Conversation
The context cancel function was declared and deferred inside a conditional block. A defer inside a conditional is correct but subtle — particularly if the closure were later refactored to use named returns, the cancel call would silently move. Initialize cancel to a no-op func upfront so the defer is always unconditional and its scope is obvious at a glance. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cancelfunction influshwas declared inside a conditionalifblock and deferred there. While functionally correct, adeferinside a conditional is subtle: if the closure were later refactored to use named returns, the cancellation point would silently shift.cancelto a no-op function before the conditional, then deferring it unconditionally. Thedefer cancel()line is now always present at the top of the HTTP section, making the lifetime of the context cancel unambiguous.Test plan
go test ./...passes (no behavioral change, so no new tests needed)🤖 Generated with Claude Code