impr: enable spaces in preset names to unify naming logic (@byseif21)

[byseif21]

• allow spaces in preset like in tag names (displayed with spaces, stored with underscores)

[Copilot]

Pull request overview

Enables spaces in preset/tag/result-filter preset names by normalizing user input (trim + whitespace → underscores) at the schema level and updating frontend modals to rely on schema parsing while continuing to display names with spaces.

Changes:

• Add whitespace-normalizing transforms to ResultFiltersSchema.name, TagNameSchema, and PresetNameSchema.
• Update tag/preset creation & edit flows to parse/validate via the shared schemas and derive display from underscore-stored names.
• Remove ad-hoc space→underscore replacement in createFilterPreset.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
packages/schemas/src/users.ts	Normalize ResultFiltersSchema.name + TagNameSchema to allow spaces (stored as _).
packages/schemas/src/presets.ts	Normalize PresetNameSchema to allow spaces (stored as _).
frontend/src/ts/modals/new-filter-preset.ts	Parse/clean filter preset names via schema before API call.
frontend/src/ts/modals/edit-tag.ts	Remove manual cleaning; parse via schema; set display from normalized name.
frontend/src/ts/modals/edit-preset.ts	Validate preset names via schema and display space-form names; store underscore-form.

Comments suppressed due to low confidence (2)

frontend/src/ts/modals/edit-preset.ts:270

• Avoid PresetNameSchema.safeParse(...).data ?? "" here; it redundantly re-parses and the fallback can silently send an empty name if this code is refactored later. Prefer using the already-validated parsed value from the earlier safeParse (or parse) call.

  if (action === "add") {
    const configChanges = getConfigChanges();
    const activeSettingGroups = getActiveSettingGroupsFromState();
    const presetName = PresetNameSchema.safeParse(propPresetName).data ?? "";
    const response = await Ape.presets.add({
      body: {
        name: presetName,
        config: configChanges,

frontend/src/ts/modals/edit-preset.ts:307

• Same as the add branch: this re-parses propPresetName and falls back to "". Reuse the earlier validated/normalized preset name to avoid duplicate schema work and avoid any possibility of an empty name being sent.

    const configChanges = getConfigChanges();
    const activeSettingGroups: ConfigGroupName[] | null =
      state.presetType === "partial" ? getActiveSettingGroupsFromState() : null;
    const presetName = PresetNameSchema.safeParse(propPresetName).data ?? "";
    const response = await Ape.presets.save({
      body: {
        _id: presetId,
        name: presetName,
        ...(updateConfig && {