test(NODE-7462): add spec tests for disaggregated storage#4904
Merged
PavelSafronov merged 1 commit intomainfrom Mar 25, 2026
Merged
test(NODE-7462): add spec tests for disaggregated storage#4904PavelSafronov merged 1 commit intomainfrom
PavelSafronov merged 1 commit intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds new SDAM replica set spec test fixtures to validate driver behavior when setVersion is constant (disaggregated storage) and during migrations between incrementing and constant setVersion behaviors.
Changes:
- Add SDAM test for disaggregated storage where primary staleness detection relies on
electionIdwhensetVersionis unchanged. - Add SDAM migration tests covering ASC→DSC (using
setVersionASC + 1) and DSC→ASC (force reconfig with highsetVersion). - Add SDAM test ensuring host/member list updates are applied even when
setVersionandelectionIddo not change.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test/spec/server-discovery-and-monitoring/rs/migration_to_disaggregated_storage.yml | YAML fixture describing ASC→DSC forward migration behavior. |
| test/spec/server-discovery-and-monitoring/rs/migration_to_disaggregated_storage.json | Executed SDAM spec test for ASC→DSC migration scenario. |
| test/spec/server-discovery-and-monitoring/rs/migration_from_disaggregated_storage.yml | YAML fixture describing DSC→ASC reverse migration behavior. |
| test/spec/server-discovery-and-monitoring/rs/migration_from_disaggregated_storage.json | Executed SDAM spec test for DSC→ASC migration scenario. |
| test/spec/server-discovery-and-monitoring/rs/member_list_update_with_unchanged_setversion_and_electionid.yml | YAML fixture for member list changes without setVersion/electionId changes. |
| test/spec/server-discovery-and-monitoring/rs/member_list_update_with_unchanged_setversion_and_electionid.json | Executed SDAM spec test ensuring host list updates are still applied. |
| test/spec/server-discovery-and-monitoring/rs/disaggregated_storage_setversion.yml | YAML fixture for constant setVersion + changing electionId behavior. |
| test/spec/server-discovery-and-monitoring/rs/disaggregated_storage_setversion.json | Executed SDAM spec test validating staleness logic with constant setVersion. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
PavelSafronov
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Summary of Changes
Add server discovery and monitoring tests for replica sets that use a constant setVersion value instead of incrementing it on reconfig.
Notes for Reviewers
What is the motivation for this change?
Spec PR
NODE-7462 | DRIVERS-3397
Release Highlight
Release notes highlight
Double check the following
npm run check:lint)type(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript