MONGOID-5656 - Fix broken FLE spec in mongoid/tasks/database_rake_spec#5690
Open
johnnyshields wants to merge 6 commits intomongodb:masterfrom
Open
MONGOID-5656 - Fix broken FLE spec in mongoid/tasks/database_rake_spec#5690johnnyshields wants to merge 6 commits intomongodb:masterfrom
johnnyshields wants to merge 6 commits intomongodb:masterfrom
Conversation
Contributor
Author
|
@jamis @comandeo can you try running (Note the specs will succeed if you don't have FLE enabled.) I think I'm out of my depth on this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am pretty sure this spec related to FLE is broken and Mongoid is skipping it in test runs.
This PR does not fix the missed spec run (I will raise a separate PR which adds it into Github actions), but does fix the spec itself.
You can see the failure here: https://github.com/tablecheck/mongoid-ultra/actions/runs/5989956616/job/16246745994
There are two problems:
encryptedis not configured correctly.OptionParser#order!is choking on RSpec's default--patternoption. This might be somewhat environment specific, but AFAIK RSpec injects this automatically.