-
Notifications
You must be signed in to change notification settings - Fork 44
CLOUDP-382956: fix: use spec.db as authSource in MongoDBUser connection string secret #932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
filipcirtog
wants to merge
10
commits into
master
Choose a base branch
from
CLOUDP-382956/fix-connectionstring-authsource-parameter
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
9a05aaa
bug: fix authSource param
filipcirtog 9f192b3
improvements
filipcirtog 7bb8e98
improvements
filipcirtog 478abf9
changelog
filipcirtog d35f580
Merge branch 'master' into CLOUDP-382956/fix-connectionstring-authsou…
filipcirtog cb53f5c
improvements
filipcirtog 5d0bbe2
improvements
filipcirtog 83c3d26
Merge branch 'master' into CLOUDP-382956/fix-connectionstring-authsou…
filipcirtog c490300
update changelog wording
filipcirtog a79ebd6
improvements
filipcirtog File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 6 additions & 0 deletions
6
...elog/20260324_fix_mongodbuser_use_spec_db_as_authsource_in_connection_string.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| --- | ||
| kind: fix | ||
| date: 2026-03-24 | ||
| --- | ||
|
|
||
| * **MongoDBUser**: Correctly set `authSource` in the generated connection string secret to reflect `spec.db` instead of hardcoding it to `admin`. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 changes: 16 additions & 0 deletions
16
...r/mongodb-kubernetes-tests/tests/authentication/fixtures/scram-sha-user-non-admin-db.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| --- | ||
| apiVersion: mongodb.com/v1 | ||
| kind: MongoDBUser | ||
| metadata: | ||
| name: mms-user-2 | ||
| spec: | ||
| passwordSecretKeyRef: | ||
| name: mms-user-2-password | ||
| key: password | ||
| username: "mms-user-2" | ||
| db: "testdb" | ||
| mongodbResourceRef: | ||
| name: "my-replica-set" | ||
| roles: | ||
| - db: "testdb" | ||
| name: "readWrite" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test ignores the error returned by
client.Create(...). If the replica set object fails to create, the test could proceed and fail later in a less clear way. Please assertrequire.NoError(t, client.Create(...))(or similar) here for clearer failures.