SERVER-129760: Repeatedly creating and dropping the same TTL index ca… - #1818
Open
ycycyyc wants to merge 1 commit into
Open
SERVER-129760: Repeatedly creating and dropping the same TTL index ca…#1818ycycyyc wants to merge 1 commit into
ycycyyc wants to merge 1 commit into
Conversation
AlexTalks
self-requested a review
July 14, 2026 21:37
AlexTalks
requested changes
Jul 28, 2026
AlexTalks
left a comment
AlexTalks
left a comment
Contributor
There was a problem hiding this comment.
This generally makes sense, though I have a minor change request.
| _deregisterTTLInfo_inlock(uuid, info); | ||
| } | ||
|
|
||
| void TTLCollectionCache::_deregisterTTLInfo_inlock(UUID uuid, const Info& info) { |
Contributor
There was a problem hiding this comment.
Generally, we'd use the WithLock utility for something like this. So it would look like _deregisterTTLInfo(WithLock, UUID uuid, const Info& info).
ycycyyc
force-pushed
the
yc-fix-SERVER-129760
branch
from
August 21, 2026 01:21
5321180 to
3fbde8c
Compare
AlexTalks
requested changes
Aug 27, 2026
| void TTLCollectionCache::_deregisterTTLInfo(WithLock, const UUID& uuid, const Info& info) { | ||
| auto infoIt = _ttlInfos.find(uuid); | ||
| if (infoIt == _ttlInfos.end()) { | ||
| LOGV2_DEBUG(9150100, |
Contributor
There was a problem hiding this comment.
Hmm, one thing I didn't notice earlier is that on each first registration of TTL info, we'll emit this log message. Can we change this so that we don't have this log message emitted on each initial registration? (Potentially with a flag I suppose)
AlexTalks
requested changes
Aug 27, 2026
| auto infoInvalid = TTLCollectionCache::Info{ | ||
| "collA_ttl_1", TTLCollectionCache::Info::ExpireAfterSecondsType::kInvalid}; | ||
| auto infoInt = TTLCollectionCache::Info{ | ||
| "collA_ttl_1", TTLCollectionCache::Info::ExpireAfterSecondsType::kInt}; |
Contributor
There was a problem hiding this comment.
Make sure to run bazel run lint and bazel run format, it seems like this may be failing linting rules.
…uses the TTL job to run multiple times within a single cycle
ycycyyc
force-pushed
the
yc-fix-SERVER-129760
branch
from
September 3, 2026 03:36
3fbde8c to
1a7cfac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: https://jira.mongodb.org/browse/SERVER-129760