Add [[nodiscard]] to view-returning public methods#1600
Closed
DaviBaum wants to merge 1 commit intomongodb:masterfrom
Closed
Add [[nodiscard]] to view-returning public methods#1600DaviBaum wants to merge 1 commit intomongodb:masterfrom
DaviBaum wants to merge 1 commit intomongodb:masterfrom
Conversation
Annotate public methods returning non-owning view types with [[nodiscard]] to catch accidental discard of return values at compile time. Covers both v1/ and v_noabi/ namespaces across bsoncxx and mongocxx headers. Target return types include document::view, array::view, element::view, string_view, types::view, bson_value::view, view_or_value, and optional<> wrappers around these types.
3c16e5a to
1f8ce2c
Compare
Collaborator
|
Thank you for the contribution @DaviBaum. Closing since we do not want to proceed with this change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[[nodiscard]]across bothv1/andv_noabi/namespaces inbsoncxxandmongocxxheaders.document::view,array::view,element::view,string_view,types::view,bson_value::view,view_or_value, andoptional<>wrappers around these types.-Wunused-result.Scope
[[nodiscard]]is a compile-time warning only.operator view(),operator bool()) and XMACRO-generatedget_*()methods are intentionally excluded.uv run --frozen etc/format.py.Test plan
cmake --build build --target bsoncxx_shared mongocxx_sharedpasses with zero errors.