fix(manifest): clean up import temp zip and use tmpdir#164
Open
codyfrisch wants to merge 1 commit intomondaycom:masterfrom
Open
fix(manifest): clean up import temp zip and use tmpdir#164codyfrisch wants to merge 1 commit intomondaycom:masterfrom
codyfrisch wants to merge 1 commit intomondaycom:masterfrom
Conversation
- Write compressFilesToZip output under os.tmpdir() with a unique name instead of cwd temp.zip (avoids leaks and concurrent clashes). - uploadManifestTsk always unlinks the zip in finally (best-effort). - Add unit tests for uploadManifestTsk cleanup on success and failure. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
compressFilesToZipnow writes toos.tmpdir()asmapps-compress-<uuid>.zipinstead of a fixedtemp.zipin the process cwd (avoids leftover files and concurrent clashes).uploadManifestTskremoves the zip path infinally(best-effort), then the existing.processedmanifest cleanup.Tests
uploadManifestTsk: assertunlinkruns for both the zip path and.processedmanifest on success and when upload fails after the zip is created.Closes #163
Made with Cursor