Fix: respect pre-existing env vars over .mappsrc config file

src/services/__tests__/config-service.test.ts

@@ -0,0 +1,61 @@
+import { describe, expect, it, beforeEach, afterEach } from '@jest/globals';
+import { existsSync, mkdirSync, writeFileSync, unlinkSync, rmSync } from 'node:fs';
+import { join } from 'node:path';
+import { tmpdir } from 'node:os';
+
+import { ConfigService, CONFIG_NAME } from 'services/config-service';
+
+describe('ConfigService', () => {
+  let testDir: string;
+
+  beforeEach(() => {
+    testDir = join(tmpdir(), `mapps-test-${Date.now()}`);
+    mkdirSync(testDir, { recursive: true });
+  });
+
+  afterEach(() => {
+    // Clean up env vars
+    delete process.env.MONDAY_CODE_ACCESS_TOKEN;
+
+    // Clean up temp dir
+    if (existsSync(testDir)) {
+      rmSync(testDir, { recursive: true, force: true });
+    }
+  });
+
+  describe('loadConfigToProcessEnv', () => {
+    it('should load config file values into process.env', () => {
+      const configData = { accessToken: 'file-token' };
+      writeFileSync(join(testDir, CONFIG_NAME), JSON.stringify(configData), 'utf8');
+
+      ConfigService.loadConfigToProcessEnv(testDir);
+
+      expect(process.env.MONDAY_CODE_ACCESS_TOKEN).toBe('file-token');
+    });
+
+    it('should not overwrite a pre-existing env var with the config file value', () => {
+      process.env.MONDAY_CODE_ACCESS_TOKEN = 'env-token';
+
+      const configData = { accessToken: 'file-token' };
+      writeFileSync(join(testDir, CONFIG_NAME), JSON.stringify(configData), 'utf8');
+
+      ConfigService.loadConfigToProcessEnv(testDir);
+
+      expect(process.env.MONDAY_CODE_ACCESS_TOKEN).toBe('env-token');
+    });
+  });
+
+  describe('init', () => {
+    it('should force-set env var even if one already exists when setInProcessEnv is true', () => {
+      process.env.MONDAY_CODE_ACCESS_TOKEN = 'old-token';
+
+      ConfigService.init(
+        { accessToken: 'new-init-token' },
+        testDir,
+        { setInProcessEnv: true },
+      );
+
+      expect(process.env.MONDAY_CODE_ACCESS_TOKEN).toBe('new-init-token');
+    });
+  });
+});

src/services/config-service.ts

@@ -36,10 +36,12 @@ const generateConfigKeyInProcessEnv = (configKey: keyof ConfigData) => {
   return configKeyInProcessEnv;
 };
 
-const setConfigDataInProcessEnv = (data: ConfigData) => {
+const setConfigDataInProcessEnv = (data: ConfigData, force = false) => {
   for (const [key, value] of Object.entries(data)) {
     const configKeyInProcessEnv = generateConfigKeyInProcessEnv(key as keyof ConfigData);
-    process.env[configKeyInProcessEnv] = value;
+    if (force || !process.env[configKeyInProcessEnv]) {
+      process.env[configKeyInProcessEnv] = value;
+    }
   }
 };
 
@@ -107,7 +109,7 @@ export const ConfigService = {
         writeConfig(mergedData, directoryPath, fileName);
       }
 
-      if (options.setInProcessEnv) setConfigDataInProcessEnv(data);
+      if (options.setInProcessEnv) setConfigDataInProcessEnv(data, true);
 
       return data;
     } catch (error) {