Improve workspace fetch with member param by shaneer · Pull Request #182 · mondaycom/mcp

shaneer · 2025-12-30T14:04:24Z

https://monday.monday.com/boards/8222767873/views/175916623/pulses/10906328723

TLDR;
Using the new membershipKind enum to fetch first only the workspaces that I am a member of and then falling back to all if not found

Main change: workspace fetch now tries first membershipKind='member', recently added by layout team, and falls back to fetching all workspaces if none found - this greatly reduces the number of workspaces returned and the hypothesis is that this is a significant optimization for the tool

Additional Small Changes

list-workspace-tool implementation adjusted, added validation to avoid returning undefined, and small renames/unification and formatting clean-ups.
updated monday-graphql schema

…improvement # Conflicts: # packages/agent-toolkit/src/core/tools/platform-api-tools/list-workspace-tool/list-workspace-tool.test.ts # packages/agent-toolkit/src/core/tools/platform-api-tools/list-workspace-tool/list-workspace-tool.ts # packages/agent-toolkit/src/monday-graphql/schema.graphql

… of endpoint

…f client package

packages/agent-toolkit/src/core/tools/platform-api-tools/base-monday-api-tool.ts

...s/agent-toolkit/src/core/tools/platform-api-tools/list-workspace-tool/list-workspace-tool.ts

damian-rakus · 2026-01-05T16:21:29Z

...s/agent-toolkit/src/core/tools/platform-api-tools/list-workspace-tool/list-workspace-tool.ts

+    let workspaces = filterNullWorkspaces(res);
+    let usedMemberOnly = true;
+
+    // If searching with a term and no matches found in member workspaces, try with all workspaces


Hey Shanee, can we include the comment that we don't allow "LLM filtering" at this point as it could cause the MCP to never search for all workspaces?
Cause initially I was surprised why we don't return those workspaces if the length is smaller than DEFAULT_WORKSPACE_LIMIT and comment here would be helpful for other devs

…orkspaces if no member workspaes are found

packages/agent-toolkit/src/utils/tests/array.utils.test.ts

RomKadria · 2026-01-05T17:30:08Z

...s/agent-toolkit/src/core/tools/platform-api-tools/list-workspace-tool/list-workspace-tool.ts

    .default(DEFAULT_WORKSPACE_LIMIT)
-    .describe(`The number of workspaces to return. Default and maximum allowed is ${DEFAULT_WORKSPACE_LIMIT}`),
-  page: z.number().min(1).default(1).describe('The page number to return. Default is 1.'),
+    .describe(`Number of workspaces to return. Default and max allowed is ${DEFAULT_WORKSPACE_LIMIT}`),


in general, why would we want the max to be the default, gives no insentive to use something else xD

For accounts that don't have a large amount of workspaces we want to return 'as much as possible' to hopefully catch all of them, hence setting the default to max here however we do want to allow peple to lower it since the whole reasoning behind Damian's original limit here was to limit the # of workspaces returned to the context so it doesn't crash - not suree this will ever be used tho since it's not specified so I'll add a explanation

packages/agent-toolkit/src/utils/array.utils.ts

RomKadria · 2026-01-05T17:36:04Z

...s/agent-toolkit/src/core/tools/platform-api-tools/list-workspace-tool/list-workspace-tool.ts

+    });
+
+    // First, try to get workspaces where the user is a member (more relevant results)
+    let res = await this.mondayApi.request<ListWorkspacesQueryResponse>(


its funny to me we are trying t create search logic here 😂
I wonder how good does it work, we dont have metric on the misses which is unfortunate here
if we have a lot of misses we just make doulbe api queries...

Once the MCP is internal we can add logs for things like this :)
For now I guess our only option would be thru BB events
We can examine in BB or in your tracing tool how many times one user calls this tools multiple times right after the other

its not about one tool one after the other, as this is two gql calls in the same tool call. we can trace it today I think anyway and check it but yeah looks...

.../agent-toolkit/src/core/tools/platform-api-tools/list-workspace-tool/list-workspace.types.ts

.../agent-toolkit/src/core/tools/platform-api-tools/list-workspace-tool/list-workspace.utils.ts

…for null

…improvement # Conflicts: # packages/agent-toolkit/src/core/tools/platform-api-tools/get-board-items-page-tool/get-board-items-page-tool.ts # packages/agent-toolkit/src/monday-graphql/generated/graphql.dev/graphql.ts # packages/agent-toolkit/src/monday-graphql/generated/graphql/graphql.ts # packages/agent-toolkit/src/monday-graphql/schema.dev.graphql # packages/agent-toolkit/src/monday-graphql/schema.graphql

damian-rakus

Looks great, just need to update version in package.json I believe as some time has passed

RomKadria · 2026-02-03T17:40:03Z

...s/agent-toolkit/src/core/tools/platform-api-tools/list-workspace-tool/list-workspace-tool.ts

    .default(DEFAULT_WORKSPACE_LIMIT)
-    .describe(`The number of workspaces to return. Default and maximum allowed is ${DEFAULT_WORKSPACE_LIMIT}`),
-  page: z.number().min(1).default(1).describe('The page number to return. Default is 1.'),
+    .describe(`Number of workspaces to return. Set to max (${DEFAULT_WORKSPACE_LIMIT}) lower for smaller response size`),


I dont understand this sentence xD

RomKadria · 2026-02-03T17:43:52Z

packages/agent-toolkit/src/utils/array.utils.ts

@@ -0,0 +1,3 @@
+export function hasElements<T>(arr: readonly T[] | null | undefined): arr is readonly T[] & { length: number } {


if you dont mind xD I think better name would have the array word in it just so itl be more redable in the code itself as we dont know by looking straight its from array utils

so something like arrayHasElements or arrayNotEmpty

RomKadria · 2026-02-03T17:48:08Z

...s/agent-toolkit/src/core/tools/platform-api-tools/list-workspace-tool/list-workspace-tool.ts


-    const shouldIncludeNoFilteringDisclaimer = searchTermNormalized && workspaces.length <= DEFAULT_WORKSPACE_LIMIT;
-    const filteredWorkspaces = this.filterWorkspacesIfNeeded(searchTermNormalized, workspaces, input);
+    // If the number of workspaces is small we prefer not filter and return all workspaces to LLM to filter


I understand its the same logic so just as fyi, I dont understand why would we want to pollute context in this scneario with more data, but I think this is the kind of query that will be removed if we ahve proper search

Actually I wonder, dont we get this from search? can we remove this tool???

" // WORKSPACES = 'WORKSPACES', // already supported by list_workspaces tool"
I. wonder why cant we add this there instead?

and remove this tool

RomKadria · 2026-02-03T17:51:38Z

.../agent-toolkit/src/core/tools/platform-api-tools/list-workspace-tool/list-workspace.utils.ts

+import { DEFAULT_WORKSPACE_LIMIT } from './list-workspace.consts';
+import { ListWorkspacesQuery } from '../../../../monday-graphql/generated/graphql/graphql';
+
+type Workspace = NonNullable<NonNullable<ListWorkspacesQuery['workspaces']>[number]>;


shaneer added 9 commits December 30, 2025 16:03

simple rename for unificatoin

9efd86c

improve fetch workspaces

5b9ed21

fix to not return undefined as well as validation on length checks

06a780e

update schema

46806de

update to use membership kind enum + update to client to deprecate us…

1212866

… of endpoint

adding dev api client as option for any tool - fixes due to upgrade o…

cd472b8

…f client package

revert endpoint changes

8a13320

formatting clean up

4464106

shaneer requested review from RomKadria and damian-rakus and removed request for RomKadria January 5, 2026 12:31

RomKadria reviewed Jan 5, 2026

View reviewed changes

packages/agent-toolkit/src/core/tools/platform-api-tools/base-monday-api-tool.ts Outdated Show resolved Hide resolved

damian-rakus reviewed Jan 5, 2026

View reviewed changes

...s/agent-toolkit/src/core/tools/platform-api-tools/list-workspace-tool/list-workspace-tool.ts Outdated Show resolved Hide resolved

clean up and use override for dev version

e45a251

damian-rakus reviewed Jan 5, 2026

View reviewed changes

...s/agent-toolkit/src/core/tools/platform-api-tools/list-workspace-tool/list-workspace-tool.ts Outdated Show resolved Hide resolved

damian-rakus reviewed Jan 5, 2026

View reviewed changes

...s/agent-toolkit/src/core/tools/platform-api-tools/list-workspace-tool/list-workspace-tool.ts Outdated Show resolved Hide resolved

damian-rakus reviewed Jan 5, 2026

View reviewed changes

isEmpty util and ensure that without search term we still fetch all w…

dd42e3e

…orkspaces if no member workspaes are found

RomKadria reviewed Jan 5, 2026

View reviewed changes

packages/agent-toolkit/src/utils/tests/array.utils.test.ts Show resolved Hide resolved

RomKadria reviewed Jan 5, 2026

View reviewed changes

shaneer added 7 commits January 6, 2026 00:50

use generated type and inverse util function to avoid returning true …

fb60873

…for null

better naming

1865000

type update

4128af7

update readme

dfe973c

clean up

cfdb207

cleaner definitions

b8dd904

shaneer requested a review from damian-rakus February 3, 2026 10:29

shaneer requested a review from RomKadria February 3, 2026 10:29

damian-rakus approved these changes Feb 3, 2026

View reviewed changes

RomKadria reviewed Feb 3, 2026

View reviewed changes

RomKadria approved these changes Feb 3, 2026

View reviewed changes

		@@ -0,0 +1,3 @@
		export function hasElements<T>(arr: readonly T[] \| null \| undefined): arr is readonly T[] & { length: number } {

Conversation

shaneer commented Dec 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

damian-rakus left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

shaneer commented Dec 30, 2025 •

edited

Loading

damian-rakus left a comment •

edited

Loading