Add Decentra Mainnet Monad#902
Conversation
Greptile SummaryThis PR adds a new mainnet validator entry for Decentra (validator ID 206) to the Key changes:
Issues found:
Confidence Score: 5/5Safe to merge; remaining findings are minor style issues that do not affect on-chain correctness or CI validation. All P0/P1 concerns are handled by the existing CI pipeline (on-chain key verification, logo URL reachability, schema validation). The two findings — ephemeral image host and missing trailing newline — are purely P2 style concerns with no impact on functional correctness. No files require special attention beyond the two minor style notes on the single changed file. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[PR: Add Decentra validator JSON] --> B[CI: check.yaml triggered]
B --> C[validate.py runs on changed file]
C --> D{JSON schema valid?}
D -- No --> FAIL1[❌ Fail: schema mismatch]
D -- Yes --> E{Logo URL accessible and returns image?}
E -- No --> FAIL2[❌ Fail: bad logo URL]
E -- Yes --> F{On-chain secp/bls match local values?}
F -- No --> FAIL3[❌ Fail: key mismatch]
F -- Yes --> G{Filename == secp.json?}
G -- No --> FAIL4[❌ Fail: filename mismatch]
G -- Yes --> SUCCESS[✅ Validation passed]
SUCCESS --> H[generate-validators.yml: rebuild mainnet_validators.json]
H --> I[Upload to R2 / CDN]
Reviews (1): Last reviewed commit: "Add Decentra Mainnet Monad" | Re-trigger Greptile |
| "bls": "803d414bba9fa06c888b4e0b2cc2ad23aa8cf6098a16c76dd357131f90967638fc31329ef085b5953dc9deb3b3f32ccb", | ||
| "website": "https://decentra.cloud/", | ||
| "description": "Crypto Infrastructure, Redefined", | ||
| "logo": "https://i.ibb.co/v6ZDhGL4/pfp-black.png", |
There was a problem hiding this comment.
Ephemeral image hosting for logo
The logo URL points to i.ibb.co (ImgBB), a free image hosting service. Free hosts can delete images, rate-limit requests, or shut down without notice, causing the logo to break for all consumers of this validator data. Other validators in this repo use self-hosted or stable CDN URLs (S3 buckets, GitHub raw content, cloudfront, etc.). Consider uploading the image to a more durable storage location before merging.
mainnet/03bddedc6b130cce8d610b3caa91b072348168181870427c7e2a5e50857af93e1b.json
Outdated
Show resolved
Hide resolved
…50857af93e1b.json Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
No description provided.