Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feat/flower containers #985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: epic/flower-2
Are you sure you want to change the base?
Uh oh!
There was an error while loading. Please reload this page.
Feat/flower containers #985
Changes from all commits
3a821d33910e781e1db1c61e830be891642799e9b5c1460d7File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
Check failure on line 336 in armadillo/src/main/java/org/molgenis/armadillo/container/DockerService.java
Use try-with-resources or close this "CreateNetworkCmd" in a "finally" clause.
Check failure on line 4 in armadillo/src/main/java/org/molgenis/armadillo/container/FlowerContainer.java
Move constants defined in this interfaces to another class or enum.
Check warning on line 17 in armadillo/src/main/java/org/molgenis/armadillo/container/FlowerSuperexecContainerConfig.java
"getName" is defined in the "ContainerConfig" interface and can be removed from this class.
Check warning on line 20 in armadillo/src/main/java/org/molgenis/armadillo/container/FlowerSuperexecContainerConfig.java
"getImage" is defined in the "ContainerConfig" interface and can be removed from this class.
Check warning on line 24 in armadillo/src/main/java/org/molgenis/armadillo/container/FlowerSuperexecContainerConfig.java
"getHost" is defined in the "ContainerConfig" interface and can be removed from this class.
Check warning on line 28 in armadillo/src/main/java/org/molgenis/armadillo/container/FlowerSuperexecContainerConfig.java
"getPort" is defined in the "ContainerConfig" interface and can be removed from this class.
Check warning on line 32 in armadillo/src/main/java/org/molgenis/armadillo/container/FlowerSuperexecContainerConfig.java
"getImageSize" is defined in the "ContainerConfig" interface and can be removed from this class.
Check warning on line 36 in armadillo/src/main/java/org/molgenis/armadillo/container/FlowerSuperexecContainerConfig.java
"getInstallDate" is defined in the "ContainerConfig" interface and can be removed from this class.
Check warning on line 40 in armadillo/src/main/java/org/molgenis/armadillo/container/FlowerSuperexecContainerConfig.java
"getLastImageId" is defined in the "ContainerConfig" interface and can be removed from this class.
Check warning on line 44 in armadillo/src/main/java/org/molgenis/armadillo/container/FlowerSuperexecContainerConfig.java
"getDockerArgs" is defined in the "ContainerConfig" interface and can be removed from this class.
Check warning on line 48 in armadillo/src/main/java/org/molgenis/armadillo/container/FlowerSuperexecContainerConfig.java
"getDockerOptions" is defined in the "ContainerConfig" interface and can be removed from this class.
Check warning on line 52 in armadillo/src/main/java/org/molgenis/armadillo/container/FlowerSuperexecContainerConfig.java
"getVersionId" is defined in the "OpenContainer" interface and can be removed from this class.
Check warning on line 56 in armadillo/src/main/java/org/molgenis/armadillo/container/FlowerSuperexecContainerConfig.java
"getCreationDate" is defined in the "OpenContainer" interface and can be removed from this class.
Uh oh!
There was an error while loading. Please reload this page.