refactor: copy in central-settlement codebase#1286
Draft
lewisdaly wants to merge 10 commits intomojaloop:mainfrom
Draft
refactor: copy in central-settlement codebase#1286lewisdaly wants to merge 10 commits intomojaloop:mainfrom
lewisdaly wants to merge 10 commits intomojaloop:mainfrom
Conversation
9ccbea9 to
e6c0bf9
Compare
e6c0bf9 to
7ca61ab
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Copies across central-settlement into the central-ledger codebase. This is necessary step for the TigerBeetle Integration.
The settlement api is now available under
/v2/:Additionally, this architecture change will make the total codebase much simpler by:
central-ledgerwill no longer need to publish a@mojaloop/central-ledgerpackage for consumption bycentral-settlement.So we go from this dependency tree:
To this dependency tree:

I chose to keep the settlement code under
src/settlementfor now to simplify the review process, and make it easier in the short term to keep the two repositories in sync with one another.For deployments, we have 2 options (we may want to choose either depending on the scenario):
central-ledgercontainer in the place of the settlement container, essentially running central-ledger as settlement.central-settlementcontainer altogether, and update routes accordingly.Recommended Followup Processes:
central-ledgerand test.central-settlementrepository as archive only.src/settlementinto the appropriate places insrc/.test/settlement.