feat(settings): allow negative delivery and payment costs#246
Open
Ibochkarev wants to merge 1 commit intomodx-pro:betafrom
Open
feat(settings): allow negative delivery and payment costs#246Ibochkarev wants to merge 1 commit intomodx-pro:betafrom
Ibochkarev wants to merge 1 commit intomodx-pro:betafrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Описание
Добавляет поддержку отрицательной дополнительной стоимости для способов доставки и оплаты.
Поле
priceтеперь может хранить фиксированные скидки (-10) и процентные скидки (-10%) так же, как положительные наценки. Для сохранения настроек добавлен общий нормализаторPriceAdjustment, чтобы manager API и legacy processors одинаково обрабатывали значения с запятыми, процентами и лишними символами.Тип изменений
Связанные Issues
Closes #211
Как это было протестировано?
Проверены синтаксис изменённых PHP-файлов, diff на whitespace-ошибки и smoke-кейсы нормализации/расчёта для
PriceAdjustment(10,-10,10%,-10%,1,5%,101%).php -l,git diff --check, PHP smoke test)Конфигурация тестирования:
beta>=8.2Скриншоты (если применимо)
Не применимо.
Чеклист
Дополнительные заметки
Перед PR проведён code review текущего diff: старые положительные сценарии
10и10%сохраняют прежний расчёт, новые отрицательные значения работают как скидки. Отдельный PHPUnit-набор в репозитории не найден.