Skip to content

Added train_fmu_gym to tools.json#834

Merged
chrbertsch merged 1 commit intomodelica:mainfrom
JohannesUl:main
Dec 9, 2025
Merged

Added train_fmu_gym to tools.json#834
chrbertsch merged 1 commit intomodelica:mainfrom
JohannesUl:main

Conversation

@JohannesUl
Copy link
Contributor

No description provided.

Copy link
Collaborator

@chrbertsch chrbertsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding your tool!

For the "examplesURL" you provide "https://codebase.helmholtz.cloud/dlr-vsdc/train_fmu_gym".
However there I do not find information, for which FMUs you have tested your implementatation (e.g. Reference FMUs, Dymola, ....)
Could you add section "Compatbility information" in the README.md?
As you use fmpy, you could also add a statement, that you support import all FMUs that are supported by fmpy.

@JohannesUl
Copy link
Contributor Author

@chrbertsch: Thanks for the comment. I will add the information in the next public version.

@chrbertsch
Copy link
Collaborator

chrbertsch commented Dec 9, 2025

@chrbertsch: Thanks for the comment. I will add the information in the next public version.

Could you not just update the README.md independent from the release?
Or remove the exmplesURL from this PR and add it once you have added the "Compatibility information"?

@JohannesUl
Copy link
Contributor Author

I updated the README.md with the compatibility information and information about the compatibility tests.

@chrbertsch chrbertsch merged commit 6c6d59a into modelica:main Dec 9, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants