[Server] Reorganize server handlers and transport structure for better organization#86
Merged
chr-hertel merged 5 commits intomodelcontextprotocol:mainfrom Sep 28, 2025
Conversation
5de7aa1 to
7b136fd
Compare
5330c2e to
c1b41af
Compare
c1b41af to
c48732c
Compare
Member
|
in general i'm fine with this change, couple of thoughts tho:
|
chr-hertel
approved these changes
Sep 28, 2025
Contributor
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reorganizes the internal server structure to improve code organization and maintainability.
Changes
Handler Reorganization
JsonRpc/Handler→Server/Handler/JsonRpcHandlerServer/RequestHandler/→Server/Handler/Request/Server/NotificationHandler/→Server/Handler/Notification/MethodHandlerInterface→Server/Handler/namespaceTransport Structure
TransportInterface→Server/Transport/namespaceData Structure
Page.php→Schema/namespaceWhy
Better Organization
Separation of Concerns
JsonRpcHandleris server implementation, not global protocolMessageFactorystays inJsonRpc/for reusabilityPageis a data structure, not server logicBreaking Changes