feat(client): send MCP standard POST headers#894
Open
AndreKalberer wants to merge 2 commits into
Open
Conversation
AndreKalberer
marked this pull request as ready for review
July 16, 2026 22:59
devcrocod
requested changes
Jul 21, 2026
|
|
||
| val paramsObject = params as? JsonObject ?: return@headers | ||
| val mcpName = paramsObject.stringValue("name") ?: paramsObject.stringValue("uri") | ||
| mcpName?.let { append(MCP_NAME_HEADER, it) } |
Contributor
There was a problem hiding this comment.
I think this PR does not follow the value encoding specified in the spec. Please take a look: https://modelcontextprotocol.io/specification/draft/basic/transports/streamable-http#value-encoding
Author
There was a problem hiding this comment.
Addressed in commit bb8ff1a. Mcp-Name now uses the specified Base64 sentinel encoding for non-ASCII or control characters, leading or trailing whitespace, and sentinel-shaped values. I added exact regression coverage for each case and reran the focused JVM tests, ktlint, detekt, API checks, and multiplatform compilation; all pass. AI assistance was used while preparing this response; I reviewed and take responsibility for the change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
SEP-2243 requires Streamable HTTP clients to mirror applicable JSON-RPC request metadata into standard HTTP headers. The Kotlin client currently sends
Mcp-Protocol-Versionand session metadata but does not emitMcp-MethodorMcp-Name.Solution
Mcp-Methodfor JSON-RPC requests and notifications.Mcp-Namefrom a stringparams.name, falling back to a stringparams.uri.Validation
.\gradlew.bat :kotlin-sdk-client:jvmTest --tests "io.modelcontextprotocol.kotlin.sdk.client.streamable.http.StreamableHttpClientTransportTest".\gradlew.bat :kotlin-sdk-client:ktlintCheck :kotlin-sdk-client:detekt :kotlin-sdk-client:apiCheckgit diff --checkCloses #787
AI assistance was used while preparing this PR. I reviewed the final change, ran the validation listed above, and take responsibility for it.