fix: resolve sandbox_proxy.html path in Docker container#1736
Open
safe049 wants to merge 1 commit into
Open
Conversation
The compiled server looks for sandbox_proxy.html at join(__dirname, '..', 'static', ...) which resolves to /app/server/static/ in Docker. However, the Dockerfile only copies server/build/ to the production image, not server/static/. Fix: reference static files relative to the build output (join(__dirname, 'static', ...)) since the build process already copies static/ into build/static/. Also add explicit COPY of server/static/ in the Dockerfile as a safety net. Fixes modelcontextprotocol#1082
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The compiled server looks for sandbox_proxy.html at join(__dirname, '..', 'static', ...) which resolves to /app/server/static/ in Docker. However, the Dockerfile only copies server/build/ to the production image, not server/static/.
reference static files relative to the build output (join(__dirname, 'static', ...)) since the build process already copies static/ into build/static/. Also add explicit COPY of server/static/ in the Dockerfile for insurance
Type of Change
Changes Made
Related Issues
Testing
Test Results and/or Instructions
use curl -v http://localhost:6277/sandbox when you started docker container with network host,normally it return html
Screenshots are encouraged to share your testing results for this change.
Checklist
npm run prettier-fix)Breaking Changes
None
Additional Context
None