-
Notifications
You must be signed in to change notification settings - Fork 0
Flex 컴포넌트 gap 단위 불일치 문제 수정 #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
yoouyeon
merged 18 commits into
hotfix/supabase-mock-api
from
fix/11-correct-flex-gap-property
Jan 13, 2026
+663
−197
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
7051d89
refactor: 인라인 스타일 제거
yoouyeon aaa6a57
chore: Storybook preview에서 Chromatic 스냅샷 기본 비활성화
yoouyeon 5f7810f
chore: Storybook MSW 애드온 추가
yoouyeon ecb7743
refactor: 로그인 페이지 진입용 LoginEntranceView 컴포넌트 분리
yoouyeon 0648d54
chore: guest·group 토큰 API에 useMock 옵션 추가
yoouyeon 04f2861
chore: Storybook 8.6.12로 업데이트
yoouyeon 20f17ac
test: Flex 프로퍼티 변경 전 스냅샷 기준용 Storybook 스토리 추가
yoouyeon 64e78e7
chore: Chromatic 스냅샷 변경에 따른 PR 코멘트 로직 개선
yoouyeon 97eb452
fix: 패딩 단위를 디자인 시스템 기준으로 수정
yoouyeon 7127074
feat: Text 컴포넌트에 style prop 추가
yoouyeon 7634487
style: ExpenseTimeHeader 레이아웃 구조 정리
yoouyeon 30f522d
refactor: AddMember 레이아웃 구조 정리
yoouyeon 8b4b01d
fix: Flex spacing 단위를 디자인 시스템 기준으로 수정
yoouyeon f45060a
design: HomePage 레이아웃 조정
yoouyeon 2f1bb2b
style: LoginEntranceView gap 단위를 디자인 시스템 기준으로 수정
yoouyeon 67a02d4
style: SelectGroupPage 레이아웃·스타일 정리
yoouyeon 747bddc
docs: Flex 컴포넌트 사용 주석 추가
yoouyeon 3a0c907
fix: width 속성 문법 오류 수정
yoouyeon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 changes: 19 additions & 0 deletions
19
src/pages/addAccountStep/ui/BankNameDrawer/index.stories.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| import { Meta, StoryObj } from '@storybook/react'; | ||
| import BankNameDrawer from './index'; | ||
|
|
||
| const meta: Meta<typeof BankNameDrawer> = { | ||
| title: 'ui/BankNameDrawer', | ||
| component: BankNameDrawer, | ||
| parameters: { | ||
| chromatic: { disableSnapshot: false }, | ||
| }, | ||
| }; | ||
|
|
||
| export default meta; | ||
| type Story = StoryObj<typeof BankNameDrawer>; | ||
|
|
||
| export const Default: Story = { | ||
| args: { | ||
| open: true, | ||
| }, | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
71 changes: 71 additions & 0 deletions
71
src/pages/billDetail/ui/ExpenseTimeHeader/index.stories.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,71 @@ | ||
| import { Meta, StoryObj } from '@storybook/react'; | ||
| import { waitFor, within } from '@storybook/test'; | ||
| import { createMemoryRouter, RouterProvider } from 'react-router'; | ||
| import { QueryClient, QueryClientProvider } from '@tanstack/react-query'; | ||
| import { http, HttpResponse } from 'msw'; | ||
| import ExpenseTimeHeader from './index'; | ||
|
|
||
| /** | ||
| * NOTE | ||
| * Flex 컴포넌트의 gap / padding 관련 변경에 대비해서 | ||
| * 스냅샷 기준을 만들기 위해 추가한 스토리입니다. | ||
| * | ||
| * 나중에 유지보수가 과도해질 경우 삭제해도 괜찮습니다. | ||
| */ | ||
|
|
||
| const queryClient = new QueryClient(); | ||
|
|
||
| const meta: Meta<typeof ExpenseTimeHeader> = { | ||
| title: 'ui/ExpenseTimeHeader', | ||
| component: ExpenseTimeHeader, | ||
| parameters: { | ||
| chromatic: { disableSnapshot: false }, | ||
| msw: { | ||
| handlers: [ | ||
| http.get('http://localhost:3000/api/v1/group/header', () => { | ||
| return HttpResponse.json({ | ||
| groupName: '모또 정기모임', | ||
| totalAmount: 150000, | ||
| deadline: '2025-12-26T23:59:59Z', | ||
| bank: '국민은행', | ||
| accountNumber: '123456-78-910111', | ||
| }); | ||
| }), | ||
| ], | ||
| }, | ||
| }, | ||
| decorators: [ | ||
| (Story) => { | ||
| const mockRouter = createMemoryRouter([ | ||
| { | ||
| path: '/*', | ||
| element: <Story />, | ||
| loader: () => ({ groupToken: 'mock-group-token' }), | ||
| }, | ||
| ]); | ||
| return ( | ||
| <QueryClientProvider client={queryClient}> | ||
| <RouterProvider router={mockRouter} /> | ||
| </QueryClientProvider> | ||
| ); | ||
| }, | ||
| ], | ||
| }; | ||
|
|
||
| export default meta; | ||
| type Story = StoryObj<typeof ExpenseTimeHeader>; | ||
|
|
||
| export const Default: Story = { | ||
| args: { | ||
| totalMember: 6, | ||
| paidMember: 3, | ||
| status: 'success', | ||
| isChecked: false, | ||
| }, | ||
| play: async ({ canvasElement }) => { | ||
| const canvas = within(canvasElement); | ||
| await waitFor(() => { | ||
| canvas.getByText('정산을 완료해주세요'); | ||
| }); | ||
| }, | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| import { Meta, StoryObj } from '@storybook/react'; | ||
| import { createMemoryRouter, RouterProvider } from 'react-router'; | ||
| import HomePage from './HomePage'; | ||
|
|
||
| const meta: Meta<typeof HomePage> = { | ||
| title: 'pages/HomePage', | ||
| component: HomePage, | ||
| parameters: { | ||
| chromatic: { disableSnapshot: false }, | ||
| }, | ||
| decorators: [ | ||
| (Story) => { | ||
| const mockRouter = createMemoryRouter([ | ||
| { | ||
| path: '/*', | ||
| element: <Story />, | ||
| }, | ||
| ]); | ||
| return <RouterProvider router={mockRouter} />; | ||
| }, | ||
| ], | ||
| }; | ||
|
|
||
| export default meta; | ||
| type Story = StoryObj<typeof HomePage>; | ||
|
|
||
| export const Default: Story = {}; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.