Open
Conversation
ngie-eign
force-pushed
the
fix-iterative-builds
branch
from
d24420d to
3b4501a
Compare
ngie-eign
force-pushed
the
fix-iterative-builds
branch
2 times, most recently
from
b914f27 to
8dfecda
Compare
ngie-eign
force-pushed
the
fix-iterative-builds
branch
from
8dfecda to
9bff8b4
Compare
No functional change intended. Signed-off-by: Enji Cooper <ngie@FreeBSD.org>
`printf` is more portable than `echo -n` for scenarios where one wants to print out a line without a trailing newline character. Signed-off-by: Enji Cooper <ngie@FreeBSD.org>
ngie-eign
force-pushed
the
fix-iterative-builds
branch
from
9bff8b4 to
4efb579
Compare
Change all hardcoded references to the special target, `.TARGET`. This avoids the need for dealing with hardcoded targets and allows them to be changed more easily. Signed-off-by: Enji Cooper <ngie@FreeBSD.org>
Prior to this change, certain build artifacts like `IMAGE`, would not be
rebuilt if the inputs to the `IMAGE` had changed and would not be
removed with the `make clean` target.
This change moves from hardcoded sentinels associated with .PHONY
targets, like `image`, away from the build artifacts they produce,
towards sentinel files, such as `${WRKDIR}/.image_done`.
This change ensures that running `make clean` results in a newly
produced image each time the sentinel is removed.
This common logic was replicated to the rest of the high-level targets,
e.g., `cd`, `gce`, etc.
Add `NO_PACKAGES` support while here. While I generally commit these
things separately, it was easier to bind the two changes together due to
the overlap.
Signed-off-by: Enji Cooper <ngie@FreeBSD.org>
ngie-eign
force-pushed
the
fix-iterative-builds
branch
from
4efb579 to
7e0926a
Compare
Owner
|
Sorry, I have been quite busy lately, I will check it next week. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Core Change
Prior to this change, certain build artifacts like
IMAGE, would not berebuilt if the inputs to the
IMAGEhad changed and would not beremoved with the
make cleantarget.This change moves from hardcoded sentinels associated with .PHONY
targets, like
image, away from the build artifacts they produce,towards sentinel files, such as
${WRKDIR}/.image_done.This change ensures that running
make cleanresults in a newlyproduced image each time the sentinel is removed.
This common logic was replicated to the rest of the high-level targets,
e.g.,
cd,gce, etc.Ancillary commits
echo -nwithprintffor portability reasons..TARGETin lieu of hardcoded equivalents when possible.