fix: improve speed in hilbert transform by FFT#284
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #284 +/- ##
==========================================
- Coverage 96.39% 96.39% -0.01%
==========================================
Files 184 184
Lines 5164 5161 -3
Branches 1151 1150 -1
==========================================
- Hits 4978 4975 -3
Misses 186 186 ☔ View full report in Codecov by Sentry. |
josoriom
approved these changes
Jan 21, 2025
lpatiny
approved these changes
Feb 12, 2025
Member
lpatiny
left a comment
lpatiny
left a comment
There was a problem hiding this comment.
If the result is the same and the algorithm is faster this PR is ok for me.
Member
|
@jobo322 why was this PR not merged ? Did you do any benchmark ? Do you know how much faster it is ? |
Member
Author
|
from the README of fft.js it may run 25% faster, but seems the improvement in speed is not than good as 25 %. at least it avoid the for loop |
jobo322
force-pushed
the
improve-hilbert-transform
branch
from
9f540ce to
74bd954
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.