feat: add chord-height curve tessellation with open-time circleSides - #192
Merged
Conversation
Short arcs now use fewer segments than a full circle, and opening a drawing without circleSides defaults to draft quality so VIEWRES 1000 is not applied accidentally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tessellate()for arcs, ellipses, splines, polylines, loops, and areas so short curves use fewer vertices than the old fixedgetPoints(100)path.circleSidesoption on the database (draft 50 by default) instead of AutoCAD VIEWRES, which is commonly stored as 1000 and would inflate GPU memory and HTML export size.Polyline,Spline,Leader,2dPolyline) and document that renderercircularArc/ellipticalArc/areaimplementations should useacdbDrawTessellateOptions.Test plan
npx jestforAcGeCurveTessellate,AcDbDrawTessellate,AcDbPolyline,AcDbSpline,AcDbLeaderAcGeCircArc2d/3d,AcGeEllipseArc3d,AcGeSpline3d,AcGePolyline2d,AcGeArea2d,AcGeLoop2d)circleSidesis passed at open timeacdbDrawTessellateOptions; example FileUpload curve-quality preset is wired through