Open
Conversation
Owner
|
Hi @evs-ch, Thanks for pr. Would you mind to make this pr to the official materializecss repo instead of here? I will update this assets base on official repo. Thanks again. |
Author
|
Makes sense, I'll do that. |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're using materialize-sass with Rails with a strict CSP config. Using
setAttribute('style', style)causes issues the style policy.element.style = ...is CSP compliant and could be used instead. jQuery offers.css(), which uses the aforementioned.style.This PR changes the problematic
setAttributecalls to using asetStyle()function which checks if jQuery is loaded and uses.css()if possible or falls back tosetAttribute.It might be possible to enhance the function to fall back to looping through the styles and directly applying them with
.style =, but I didn't look into that yet.Using this PR with appropriate settings in Rails'
content_security_policy.rbat least fixed all the CSP conflicts we had with materialize-sass.