Saji master 16 5#378
Open
ParameswaranSajeenthiran wants to merge 320 commits into
Open
Conversation
Make entity deduplication thread safe
Removed redundant constant TIME_ELAPSED_LOWER_BOUND.
Implement review changes in PR#27 (v2)
# Conflicts: # src/frontend/JasmineGraphFrontEnd.cpp # src/frontend/JasmineGraphFrontEnd.h # src/frontend/core/executor/impl/SemanticBeamSearchExecutor.cpp # src/knowledgegraph/construction/Pipeline.cpp # src/query/processor/nlp/semanticbeamsearch/SemanticBeamSearch.cpp # src/server/JasmineGraphInstanceProtocol.cpp # src/server/JasmineGraphInstanceProtocol.h # src/server/JasmineGraphInstanceService.cpp # src/util/Utils.cpp # src/util/Utils.h # src/vectorstore/FaissIndex.cpp # test-docker.sh # test-k8s.sh
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
|
|
||
| // TLS + connection settings | ||
| curl_easy_setopt(curl, CURLOPT_SSLVERSION, CURL_SSLVERSION_DEFAULT); |
| if (!leftover.empty()) { | ||
| std::unique_lock<std::mutex> lock(dataBufferMutex); | ||
| dataBuffer.push(Chunk{std::to_string(chunk_idx), std::move(leftover), 0}); | ||
| lock.unlock(); |
| dataBuffer.push(Chunk{std::to_string(chunk_idx), END_OF_STREAM_MARKER, 0}); | ||
| } | ||
| lock.unlock(); | ||
| dataBufferCV.notify_all(); |
| std::chrono::duration<double> duration = endTime - startTime; | ||
| kg_pipeline_stream_handler_logger.info("Successfully streamed data from local file into data buffer."); | ||
| kg_pipeline_stream_handler_logger.info("Time taken to read from local file: " + | ||
| std::to_string(duration.count()) + " seconds"); |
| kg_pipeline_stream_handler_logger.debug("Thread " + std::to_string(i) + | ||
| " adding local edge to partition " + | ||
| std::to_string(sourceIndex)); | ||
| partitioner.addLocalEdge(obj.dump(), sourceIndex); |
| } | ||
| } | ||
| } | ||
| kg_pipeline_stream_handler_logger.info("Tuple thread finished for partition " + std::to_string(i)); |
| JasmineGraphInstanceProtocol::CHUNK_STREAM_END, | ||
| JasmineGraphInstanceProtocol::OK)) { | ||
| kg_pipeline_stream_handler_logger.error("Failed to send END_OF_STREAM"); | ||
| } |
| if (localEdgeArrays[index].size() >= partitionFileEdgeThreshold) { | ||
| hash_partitioner_logger.debug("Adding local edge, releasing lock"); | ||
| edgeReady[index] = true; | ||
| lock.unlock(); |
| "[FaissIndex] Embedding added to index. Updating nodeEmbeddingMap."); | ||
| nodeIdToEmbeddingIdMap[nodeId] = new_id; | ||
| embeddingIdToNodeIdMap[new_id] = nodeId; | ||
| lock.unlock(); |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #378 +/- ##
=========================================
- Coverage 1.18% 1.11% -0.08%
=========================================
Files 111 118 +7
Lines 27059 29317 +2258
Branches 17705 19255 +1550
=========================================
+ Hits 321 327 +6
- Misses 26471 28716 +2245
- Partials 267 274 +7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.