Add feature to set SSH private/public key field#102
Merged
hensur merged 2 commits intomittwald:masterfrom Aug 19, 2025
Merged
Conversation
Contributor
jkupferer
commented
Sep 4, 2024
jkupferer
commented
- Add ability set privateKeyField and publicKeyField to set secret fields to store SSH private/public keys.
- Resolves Allow Customization of ssh-privatekey and ssh-publickey for SSHKeyPair #92
- Add ability set privateKeyField and publicKeyField to set secret fields to store SSH private/public keys. - Resolves mittwald#92
|
@jkupferer : Hi. The Test GH Action in your PR seems to be stuck. Close/Reopen the PR might help. |
|
Is this still being worked on? |
Contributor
Author
|
Circling back around to this... updating the PR branch. |
|
Thanks @jkupferer. I'm not sure. Is there an obvious person/group to add to the reviewers in the top right? I'm guessing as there are no reviewers, no-one is picking this up |
hensur
approved these changes
Aug 19, 2025
mhaley-tignis
pushed a commit
to tignis/kubernetes-secret-generator
that referenced
this pull request
Oct 10, 2025
- Add ability set privateKeyField and publicKeyField to set secret fields to store SSH private/public keys. - Resolves mittwald#92
mhaley-tignis
pushed a commit
to tignis/kubernetes-secret-generator
that referenced
this pull request
Oct 14, 2025
- Add ability set privateKeyField and publicKeyField to set secret fields to store SSH private/public keys. - Resolves mittwald#92
disconn3ct
added a commit
to disconn3ct/kubernetes-secret-generator
that referenced
this pull request
Nov 24, 2025
* upstream/master: Add feature to set SSH private/public key field (mittwald#102) fix: fix the wrong error return value
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.