fix(texture_gl): don't require GL 4.2 in mip level allocation#191
Merged
wjakob merged 2 commits intomitsuba-renderer:masterfrom Feb 22, 2026
Merged
fix(texture_gl): don't require GL 4.2 in mip level allocation#191wjakob merged 2 commits intomitsuba-renderer:masterfrom
wjakob merged 2 commits intomitsuba-renderer:masterfrom
Conversation
Tom94
force-pushed
the
tev-upstreaming
branch
from
11d4b9b to
1f0ab30
Compare
Tom94
changed the title
Can happens e.g. when GPU is OOM
Tom94
force-pushed
the
tev-upstreaming
branch
from
1f0ab30 to
f4f8b8b
Compare
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry, my previous PR introduced the usage of
glTexStorage2Dfor mip level pre-allocation which isn't available below OpenGL 4.2. This PR usesglTexImage2Dinstead -- verified bringing the same performance benefit. And as a by-product also supports GLES 2.