fix: make icons dir path relative to example script location#155
Open
SpotlightKid wants to merge 2 commits intomitsuba-renderer:masterfrom
Open
fix: make icons dir path relative to example script location#155SpotlightKid wants to merge 2 commits intomitsuba-renderer:masterfrom
SpotlightKid wants to merge 2 commits intomitsuba-renderer:masterfrom
Conversation
Signed-off-by: Christopher Arndt <chris@chrisarndt.de>
SpotlightKid
force-pushed
the
fix/python-example1
branch
from
dff7c7c to
7c7f9bc
Compare
Signed-off-by: Christopher Arndt <chris@chrisarndt.de>
wjakob
force-pushed
the
master
branch
9 times, most recently
from
654b8a5 to
1cbff2e
Compare
wjakob
force-pushed
the
master
branch
16 times, most recently
from
d1f7fbd to
339b241
Compare
wjakob
force-pushed
the
master
branch
9 times, most recently
from
c75898b to
1bbd038
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This way it is independent of the current working dir you are in when you run the example script and the script doesn't need to change the current working dir.
I think this a better solution than in #139.