fix(deps): update dependency @mitodl/course-search-utils to v3#1739
Open
renovate[bot] wants to merge 1 commit intomainfrom
Open
fix(deps): update dependency @mitodl/course-search-utils to v3#1739renovate[bot] wants to merge 1 commit intomainfrom
renovate[bot] wants to merge 1 commit intomainfrom
Conversation
9a06802 to
41abbb0
Compare
41abbb0 to
50c4e54
Compare
50c4e54 to
cba2743
Compare
| "@emotion/react": "^11.14.0", | ||
| "@emotion/styled": "^11.14.0", | ||
| "@mitodl/course-search-utils": "^2.3.3", | ||
| "@mitodl/course-search-utils": "^3.0.0", |
There was a problem hiding this comment.
Bug: Upgrading @mitodl/course-search-utils to a new major version with breaking changes in peer dependencies (React, history) without updating the consuming code creates a high risk of runtime errors.
Severity: HIGH
Suggested Fix
Before merging, review the changelog or migration guide for @mitodl/course-search-utils v3. The code using this library, especially the useCourseSearch hook and its reliance on the history package, should be updated to align with any breaking API changes. The react peer dependency in the library may also need to be corrected if it's a metadata error.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: package.json#L44
Potential issue: The project upgrades `@mitodl/course-search-utils` to v3.5.0, a major
version change that appears to include significant internal refactoring. The library's
peer dependencies have changed: `react` is specified as `^16.13.1` which is incompatible
with the project's React 18, and the previously required `history` package is now
optional. The `useCourseSearch` hook is still passed a `history` object, but the library
may no longer support this routing method, potentially causing runtime failures. While
the code compiles, the lack of corresponding updates in the application to accommodate
these breaking changes introduces a high risk of incompatibility.
Did we get this right? 👍 / 👎 to inform future reviews.
cba2743 to
d4bd4a8
Compare
d4bd4a8 to
9100fa0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
^2.3.3→^3.0.0Release Notes
mitodl/course-search-utils (@mitodl/course-search-utils)
v3.5.0Compare Source
v3.4.1Compare Source
v3.4.0Compare Source
v3.3.2Compare Source
v3.3.1Compare Source
v3.3.0Compare Source
v3.2.5Compare Source
v3.2.4Compare Source
v3.2.3Compare Source
v3.1.6Compare Source
v3.1.5Compare Source
v3.1.4Compare Source
v3.1.3Compare Source
v3.1.2Compare Source
v3.1.1Compare Source
v3.1.0Compare Source
v3.0.9Compare Source
v3.0.8Compare Source
v3.0.7Compare Source
v3.0.6Compare Source
v3.0.5Compare Source
v3.0.4Compare Source
v3.0.3Compare Source
v3.0.2Compare Source
v3.0.0Compare Source
Configuration
📅 Schedule: Branch creation - "every weekend" in timezone US/Eastern, Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.