fix(tests): prevent flaky dismiss in PointerEvent timestamp test#63
Merged
Conversation
|
🎉 Thanks for opening your first pull request! We're excited to review your contribution to Bootstrap Sheet. Please make sure:
A maintainer will review your PR as soon as possible. Feel free to ask questions if you need help! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a flaky test in the
Number optionssuite where the sheet was occasionally dismissed during a snap-back gesture.Type of Change
Changes Made
timeStampin thePointerEventmock (jest.setup.js) to useperformance.now()from Jest's faked clock instead of jsdom's internal real clockRoot Cause
The custom
PointerEventmock extendsMouseEvent, whose constructor setstimeStampvia jsdom's own internalperformancereference - bypassing Jest's faked clock. When two events are created in the same synchronous block, their real timestamps can differ by a few microseconds (e.g.dt = 0.001 ms).VelocityTrackerthen computes:Far above the dismiss threshold → sheet closes when it should snap back. The failure was intermittent because it depended on CPU load at the moment of event construction.
Testing
npm test)