fix: increase horizontal padding on small screens#3974
Open
salomvary wants to merge 1 commit intominiflux:mainfrom
Open
fix: increase horizontal padding on small screens#3974salomvary wants to merge 1 commit intominiflux:mainfrom
salomvary wants to merge 1 commit intominiflux:mainfrom
Conversation
I found the 3px horizontal padding between content and the edge of the viewport rather small. There is no industry standard for this, but most mobile apps and websites use more space than Miniflux. Android design guide recommends 16px: https://developer.android.com/design/ui/mobile/guides/layout-and-content/content-structure I went for 10px which together with the 3px on `main` results in 13px, looking a lot better but still quite dense.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found the 3px horizontal padding between content and the edge of the viewport rather small.
There is no industry standard for this, but most mobile apps and websites use more space than Miniflux.
Android design guide recommends 16px: https://developer.android.com/design/ui/mobile/guides/layout-and-content/content-structure
I went for 10px which together with the 3px on
mainresults in 13px, looking a lot better but still quite dense.Before:
After:
Have you followed these guidelines?