🐛 Fix macos build issues - #799
Conversation
|
Heya! Thanks for the PR. Generally looks good, just need to ensure the installation works right still on Windows and Linux as well. Should this now work out of the box on M1/2/3 Macs as well, just with requirements installed? |
|
On my M1 Pro, this works fine: (mamba is just a more efficient version of conda) mamba create --name install_minerl python=3.11
mamba activate install_minerl
mamba install conda-forge::openjdk=8
pip install git+https://github.com/yhs0602/minerlOn Linux, this works fine as well: conda create -n install_minerl python=3.11
conda activate install_minerl
conda install conda-forge::openjdk=8
pip install git+https://github.com/yhs0602/minerl🎉 However, on Windows, this does not work... Maybe I need to use WSL? conda create -n install_minerl python=3.11
conda activate install_minerl
conda install conda-forge::openjdk=8
pip install git+https://github.com/yhs0602/minerlI had to fix WSL Bash (Docker Desktop) following solution: microsoft/WSL#5923 (comment) I couldn't get pip to use Git Bash along with Conda and JDK--it kept trying to use WSL's Bash. As a result, I had to install openjdk-8-jdk on my WSL. And after that finally installing minerl on windows also succeeded 🎉 |
|
Hello, is there a plan to merge this PR, so that other MacOS users to install MineRL easily on their devices? @Miffyli |
|
Nevermind - I think we have to apply this comment's step 5 also: |
|
Hey! Sorry for dropping the ball on this (feel free to nudge me). Is adding the extra step something you'd like to add to the PR so I can test it out? |
This pull request handles