Conversation
- Fixed incorrect assignment of dm.QueryMessage and dm.ResponseMessage: - Correctly assign QueryMessage for client queries and ResponseMessage for client responses. - Added error handling for ic.Writer.Write to log write failures. - Optimized time.Now calls by caching the result to improve performance. - Enhanced safety of `send` condition by adding nil checks for MAC addresses. - Improved logging for unknown TransportLayer by including layer type information. - Refactored redundant code for setting dnstap.Message fields into a helper function to reduce duplication. - Added detailed error messages for extractLinkLayer to include packet information. - Ensured proper cleanup in Start function by adding defer handle.Close(). - Improved Setup function error messages for better clarity on invalid parameters.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.